Fix NatSpec Documentation for simulateAndRevert#935
Closed
Conversation
This PR fixes the NatSpec documentation for the `simulateAndRevert` function such that it no longer falsly claims that the `returndata` is ABI encoded `(bool, bytes)`, but instead a custom packed encoding. Shoutout to @PaulRBerg for bringing this to our attention!
remedcu
approved these changes
Apr 4, 2025
rmeissner
approved these changes
Apr 4, 2025
Contributor
Collaborator
Author
|
@PaulRBerg - of course! Closing in favour of #936 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the NatSpec documentation for the
simulateAndRevertfunction such that it no longer falsly claims that thereturndatais ABI encoded(bool, bytes), but instead a custom packed encoding.Shoutout to @PaulRBerg for bringing this to our attention!